Juju Charms Collection
nova-compute package

Merge lp://qastaging/~gnuoy/charms/trusty/nova-compute/cell-support into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next

Proposed by Liam Young on 2014-10-23

Status:	Rejected
Rejected by:	James Page on 2015-03-31
Proposed branch:	lp://qastaging/~gnuoy/charms/trusty/nova-compute/cell-support
Merge into:	lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target:	84 lines (+30/-0) 5 files modified config.yaml (+7/-0) hooks/nova_compute_context.py (+3/-0) templates/havana/nova.conf (+5/-0) templates/juno/nova.conf (+5/-0) unit_tests/test_nova_compute_contexts.py (+10/-0)
To merge this branch:	bzr merge lp://qastaging/~gnuoy/charms/trusty/nova-compute/cell-support
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
James Page		2014-10-23	Needs Fixing on 2014-11-20
Review via email: mp+239357@code.qastaging.launchpad.net

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2014-10-24:

UOSCI bot says:
charm_lint_check #749 nova-compute-next for gnuoy mp239357
LINT OK: believed to pass, but you should confirm results

LINT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.749:
I: config.yaml: option config-flags has no default value
I: config.yaml: option instances-path has no default value
W: config.yaml: option disable-neutron-security-groups has no default value
I: config.yaml: option migration-auth-type has no default value

Full lint output: http://paste.ubuntu.com/8651864/
Build: http://10.98.191.181:8080/job/charm_lint_check/749/

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2014-10-24:

UOSCI bot says:
charm_unit_test #557 nova-compute-next for gnuoy mp239357
UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.557:
----------------------------------------------------------------------
Ran 57 tests in 3.145s

OK (SKIP=5)

Full unit output: http://paste.ubuntu.com/8651865/
Build: http://10.98.191.181:8080/job/charm_unit_test/557/

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2014-10-24:

UOSCI bot says:
charm_amulet_test #302 nova-compute-next for gnuoy mp239357
AMULET OK: believed to pass, but you should confirm results

AMULET Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_amulet_test/make-test.302:
juju-test.conductor DEBUG : Tearing down osci-sv05 juju environment
juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv05"
WARNING cannot delete security group "juju-osci-sv05-0". Used by another environment?
juju-test INFO : Results: 3 passed, 0 failed, 0 errored

Full amulet output: http://paste.ubuntu.com/8652045/
Build: http://10.98.191.181:8080/job/charm_amulet_test/302/

Revision history for this message

James Page (james-page) on 2014-11-20:

review: Needs Fixing

Unmerged revisions

81. By Liam Young on 2014-10-23: Add vif unit_test
80. By Liam Young on 2014-10-23: Simplified vif plugin setup
79. By Liam Young on 2014-10-23: Remove hardcoded debug=True from havana template
78. By Liam Young on 2014-10-23: Tidy lint
77. By Liam Young on 2014-10-23: Add vif setting to juno template
76. By Liam Young on 2014-10-23: Merged next in
75. By Liam Young on 2014-10-07: Merged next in
74. By Liam Young on 2014-09-02: Rebased
73. By Liam Young on 2014-07-24: Default debug on
72. By Liam Young on 2014-07-23: Fix typo in nova template and allow vif_plugging_timeout to be toggled off