Juju Charms Collection
nova-compute package

Merge lp://qastaging/~gnuoy/charms/trusty/nova-compute/hugepage-sub-trigger into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next

  1. Trusty Tahr (14.04)
  2. hugepage-sub-trigger
  3. Merge into next
Proposed by Liam Young
Status: Merged
Merged at revision: 184
Proposed branch: lp://qastaging/~gnuoy/charms/trusty/nova-compute/hugepage-sub-trigger
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 123 lines (+36/-15)
3 files modified
hooks/nova_compute_hooks.py (+10/-0)
hooks/nova_compute_utils.py (+17/-12)
unit_tests/test_nova_compute_hooks.py (+9/-3)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charms/trusty/nova-compute/hugepage-sub-trigger
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+278817@code.qastaging.launchpad.net

Description of the change

This change sets the requests hugepage value down the relation with the neutron plugin subordinate charm. The reason for this is so that the subordinate can react to a change in that value and restart any services. This is a feature that was requested by cisco for the cisco-vpp charm

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #14477 nova-compute-next for gnuoy mp278817
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/14477/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #13496 nova-compute-next for gnuoy mp278817
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/13526567/
Build: http://10.245.162.77:8080/job/charm_unit_test/13496/

lp://qastaging/~gnuoy/charms/trusty/nova-compute/hugepage-sub-trigger updated
185. By Liam Young

Fix unit test

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8040 nova-compute-next for gnuoy mp278817
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/13527056/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8040/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #14478 nova-compute-next for gnuoy mp278817
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/14478/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #13497 nova-compute-next for gnuoy mp278817
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/13497/

Revision history for this message
James Page (james-page) wrote :

Aside from the amulet test failure this looks OK to me; please remedy as required.

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8041 nova-compute-next for gnuoy mp278817
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/13528847/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8041/

Revision history for this message
Liam Young (gnuoy) wrote :

Both amulet fails look unrelated to this branch. Both are deployments timeouts which look to me to be issues with the testing infrastructure.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Indeed, 1 instance/unit didn't come up in the amulet test.

2 pending 172.17.104.135 b78bcaf9-94ab-49b6-8e9d-0385e21ab05a wily arch=amd64 cpu-cores=1 mem=1536M root-disk=10240M availability-zone=nova

Rerunning...

Revision history for this message
James Page (james-page) :
review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8065 nova-compute-next for gnuoy mp278817
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/13600756/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8065/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches