Juju Charms Collection
percona-cluster package

Merge lp://qastaging/~gnuoy/charms/trusty/percona-cluster/1454317 into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

  1. Trusty Tahr (14.04)
  2. 1454317
  3. Merge into next
Proposed by Liam Young
Status: Work in progress
Proposed branch: lp://qastaging/~gnuoy/charms/trusty/percona-cluster/1454317
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 501 lines (+210/-40)
11 files modified
charm-helpers-hooks.yaml (+1/-1)
charmhelpers/contrib/database/mysql.py (+21/-6)
charmhelpers/contrib/network/ip.py (+5/-3)
charmhelpers/core/hookenv.py (+32/-0)
charmhelpers/core/hugepage.py (+8/-1)
charmhelpers/core/strutils.py (+30/-0)
hooks/percona_hooks.py (+21/-3)
hooks/percona_utils.py (+12/-9)
tests/charmhelpers/contrib/amulet/utils.py (+47/-16)
tests/charmhelpers/contrib/openstack/amulet/utils.py (+1/-1)
tests/charmhelpers/core/hookenv.py (+32/-0)
To merge this branch: bzr merge lp://qastaging/~gnuoy/charms/trusty/percona-cluster/1454317
Reviewer Review Type Date Requested Status
Edward Hope-Morley Needs Resubmitting
Mario Splivalo (community) Approve
OpenStack Charmers Pending
Review via email: mp+258981@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4246 percona-cluster-next for gnuoy mp258981
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [unit_test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/11115163/
Build: http://10.245.162.77:8080/job/charm_unit_test/4246/

Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #4521 percona-cluster-next for gnuoy mp258981
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11115164/
Build: http://10.245.162.77:8080/job/charm_lint_check/4521/

Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4100 percona-cluster-next for gnuoy mp258981
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11115168/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4100/

Reply
Revision history for this message
Mario Splivalo (mariosplivalo) wrote :

This looks ok to me. Verified that passwords are stored correctly in relations, adding more units doesn't break things.

The issues are amulet tests, which were included with this commit: http://bazaar.launchpad.net/~openstack-charmers/charms/trusty/percona-cluster/next/revision/54

Apparently it's an amulet issue - test raises amulet.SKIP if no AMULET_OS_VIP is configured, but amulet considers that as an error and fails the test. Same issue as with rev54 commit, probably the test should be written in a manner so that it doesn't raise. amulet.SKIP.

Otherwise, peachy!

review: Approve
Reply
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Liam, i don't see these changes in lp:charm-helpers (e.g. wipe_disk_passwords() is not in contrib.database.mysql).

review: Needs Fixing
Reply
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Ok found it (linked charm-helpers MP to LP)

Reply
Revision history for this message
Edward Hope-Morley (hopem) wrote :

This could do with a cleanup+resync.

review: Needs Resubmitting
Reply
lp://qastaging/~gnuoy/charms/trusty/percona-cluster/1454317 updated
63. By Liam Young

Merged next in

64. By Liam Young

Rebase changes

65. By Liam Young

Fix typos and lint

Unmerged revisions

65. By Liam Young

Fix typos and lint

64. By Liam Young

Rebase changes

63. By Liam Young

Merged next in

62. By Liam Young

Only add passwords to the peer relation if the unit is clustered, the leader and remove stale passwords after a slave sync. Also replace eligible_leader with is_elected_leader as eligible_leader is deprecated

61. By Liam Young

Sync charmhelpers with db fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches