Merge lp://qastaging/~goehle/evolution-indicator/dont-quit-on-close into lp://qastaging/evolution-indicator

Proposed by Geoff Goehle
Status: Needs review
Proposed branch: lp://qastaging/~goehle/evolution-indicator/dont-quit-on-close
Merge into: lp://qastaging/evolution-indicator
Diff against target: 1131 lines (+975/-24) (has conflicts)
5 files modified
ChangeLog (+628/-0)
autogen.sh (+0/-11)
configure.ac (+6/-1)
data/evolution-indicator.schemas.in (+33/-0)
src/evolution-indicator.c (+308/-12)
Text conflict in configure.ac
Text conflict in src/evolution-indicator.c
To merge this branch: bzr merge lp://qastaging/~goehle/evolution-indicator/dont-quit-on-close
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+42151@code.qastaging.launchpad.net

Description of the change

A fix of the last merge, which was bungled.

I've included functionality which allows the indicator-applet to have evolution run in the background with no open windows.

Using g_signal when the last open shell window is closed the indicator applet hides the window instead of deleting it. This gives the impression that evolution is "running in the applet".

I also implemented the ability to turn this feature on and off and to run evolution on startup.

To post a comment you must log in.
Revision history for this message
Geoff Goehle (goehle) wrote :

Still getting used to merging and bzr. Some of these changes are not intended.... The bulk should be there but lines 70-120, 190-162, 380-414, 488-565 should removed.

74. By Geoff Goehle

Fixed unintended changes and added a missing file

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks a lot for your work there, you should have a look at the ayatana discussions that took place during latest UDS, particularly this spec and the video associated. You can find the reference there:
https://lists.launchpad.net/ayatana/msg04650.html

So, even if I was convinced that the "don't quit on close" and seeing email as a service was the right stuff to do, I'm not anymore and let you raise the point on the ayatana mailing list (maybe a follow up on that email?) and asking Matthew to restate those points.

Revision history for this message
Geoff Goehle (goehle) wrote :

I can't say that I really understand the discussion, but then again I'm
a mathematician and not a coder. The distinction between "service" vs
"nonservice" appliations is lost on me...

In any case, the whole thing is kind of moot since ubuntu is moving to
unity.

On Mon, 2011-02-07 at 15:54 +0000, Didier Roche wrote:
> Thanks a lot for your work there, you should have a look at the ayatana discussions that took place during latest UDS, particularly this spec and the video associated. You can find the reference there:
> https://lists.launchpad.net/ayatana/msg04650.html
>
> So, even if I was convinced that the "don't quit on close" and seeing email as a service was the right stuff to do, I'm not anymore and let you raise the point on the ayatana mailing list (maybe a follow up on that email?) and asking Matthew to restate those points.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

> In any case, the whole thing is kind of moot since ubuntu is moving to
unity.

Why do you say that? the indicator are completely part of the unity experience, so this work is primordial.

Revision history for this message
Geoff Goehle (goehle) wrote :

I haven't used unity regularly, but from what I remember unity has the "mac" style program launchers. If there is an evolution icon on the launcher bar and evolution is minimized then there isn't a visible "window". All that changes is the icon on the launcher bar picks up a little triangle underneath, as opposed to gnome where the window stays on the task bar. So it unity you can effectively replicate the minimize to applet functionality by using the minimize button.

Still it doesn't address the fact that clicking "close" closes evolution, and it doesn't close any other Indicator Applet applications, which is a point of confusion.

75. By Geoff Goehle

Updated previous patch to work with new version of evolution indicator.
When the option is enabled the indicator will allow evolution to run
without a visible window.

76. By Geoff Goehle

Fixed unintended changes

Revision history for this message
Geoff Goehle (goehle) wrote :

Well I've been using unity since release and changed my mind about the need for "dont-quit-on-close" functionality being obsolete.

1. Space on the sidebar is at a premium. The icons are large enough that having the evolution icon there all the time adds clutter.

2. There are now 5 programs that make use of the indicator area (evolution, banshee, empathy, gwibber, and ubuntu-one). Of these evolution is the only one that doesn't run without an open window.

I updated my patch for the new version.

Unmerged revisions

76. By Geoff Goehle

Fixed unintended changes

75. By Geoff Goehle

Updated previous patch to work with new version of evolution indicator.
When the option is enabled the indicator will allow evolution to run
without a visible window.

74. By Geoff Goehle

Fixed unintended changes and added a missing file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches