kdelibs

Merge lp://qastaging/~goelkunal/kdelibs/debian into lp://qastaging/~kubuntu-packagers/kubuntu-packaging/kdelibs

  1. debian
  2. Merge into kdelibs
Proposed by KunalGoel
Status: Merged
Merge reported by: Jonathan Riddell
Merged at revision: not available
Proposed branch: lp://qastaging/~goelkunal/kdelibs/debian
Merge into: lp://qastaging/~kubuntu-packagers/kubuntu-packaging/kdelibs
Diff against target: 132 lines (+112/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/remove-direct-OpenGL-dependency-for-libplasma.diff (+104/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~goelkunal/kdelibs/debian
Reviewer Review Type Date Requested Status
Jonathan Riddell Approve
Steve Langasek Approve
Review via email: mp+51994@code.qastaging.launchpad.net

Description of the change

remove direct OpenGL dependency for libplasma

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

The patch itself seems to be straightforward, but why are the glClearColor(), glClear() calls not needed here? Presumably they were added for a reason, and we should be sure that reason no longer applies before making such a change.

I see that these API calls are also part of GLES; so if these calls need to be kept, an alternative would be for plasma to select either GL or GLES as needed.

review: Needs Information
Revision history for this message
KunalGoel (goelkunal) wrote :

The glClearColor and glClear were used in GLApplet, which is targeted to write plasmoid using OpenGL, but currently the GLApplet is not used anymore in KDE, and there is plan to re-write this part in the future for libplasma2.

For more details please check: https://git.reviewboard.kde.org/r/100705/

Revision history for this message
Steve Langasek (vorlon) wrote :

As the upstream discussion shows, even for applets using the GLApplet interface (of which there appear to not be any), these calls should not be needed here. So this change is needed on ARM, and has no adverse affects elsewhere.

review: Approve
Revision history for this message
Jonathan Riddell (jr) wrote :

Merged by Harald

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: