OpenLP

Merge lp://qastaging/~googol-deactivatedaccount/openlp/bug-970436 into lp://qastaging/openlp

  1. bug-970436
  2. Merge into trunk
Proposed by Andreas Preikschat
Status: Merged
Approved by: Tim Bentley
Approved revision: 1939
Merged at revision: 1939
Proposed branch: lp://qastaging/~googol-deactivatedaccount/openlp/bug-970436
Merge into: lp://qastaging/openlp
Diff against target: 197 lines (+30/-37)
2 files modified
openlp/core/ui/generaltab.py (+12/-15)
openlp/core/ui/maindisplay.py (+18/-22)
To merge this branch: bzr merge lp://qastaging/~googol-deactivatedaccount/openlp/bug-970436
Reviewer Review Type Date Requested Status
Tim Bentley Approve
Jonathan Corwin (community) Approve
Review via email: mp+101226@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-04-08.

Commit message

bzr merge lp:~googol/openlp/bug-970436 && bzr commit -m "fixed bug 970436 ('Display if a single screen' always in effect) and clean ups" --fixes lp:970436 --author="Andreas Preikschat <email address hidden>"

Description of the change

Hello,
- fixed bug 970436 ('Display if a single screen' always in effect)
- removed not needed attribute
- simplification + comment fixes

To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Jonathan Corwin (j-corwin) wrote : Posted in a previous version of this proposal

I was expecting this to be fixed the other way around. Allow the "Display if single screen" to still be selectable when an override monitor is used.

For example I set the override screen dimensions to mirror my church projector (1024x768) on my home computer so my themes are the correct dimensions. However I don't want it to appear so I uncheck the display if single monitor setting.

Revision history for this message
Andreas Preikschat (googol-deactivatedaccount) wrote : Posted in a previous version of this proposal

> I was expecting this to be fixed the other way around. Allow the "Display if
> single screen" to still be selectable when an override monitor is used.

I was thinking the same thing, but I decided to do it not like this.

> For example I set the override screen dimensions to mirror my church projector
> (1024x768) on my home computer so my themes are the correct dimensions.
> However I don't want it to appear so I uncheck the display if single monitor
> setting.

However, this is a good example and it convinced me. I am going to change this!

Revision history for this message
Jonathan Corwin (j-corwin) :
review: Approve
Revision history for this message
Tim Bentley (trb143) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.