Merge lp://qastaging/~gordallott/unity/dash-dnd into lp://qastaging/unity
Proposed by
Gord Allott
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Neil J. Patel | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 1420 | ||||
| Proposed branch: | lp://qastaging/~gordallott/unity/dash-dnd | ||||
| Merge into: | lp://qastaging/unity | ||||
| Diff against target: |
221 lines (+148/-1) 3 files modified
plugins/unityshell/src/ResultViewGrid.cpp (+134/-0) plugins/unityshell/src/ResultViewGrid.h (+12/-1) tests/CMakeLists.txt (+2/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~gordallott/unity/dash-dnd | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
adds dnd to the results view
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
- Do something with the &error you send to load_icon otherwise it would leak.
- A comment saying why you don't unref the pixbuf (as GdkGraphics does it for you), would be awesome.
Approving but please fix this before merging.