Merge lp://qastaging/~gordallott/unity/dash-legal-link into lp://qastaging/unity

Looks good and works well...

29 + glib::String cachedir(g_strdup(g_get_user_cache_dir()));

No need to strdup it, just assign that to std::string... It should be never NULL, in case just check for that.

30 + legal_seen_file_path_ = cachedir.Str() + "/unitydashlegalseen";

Since we have an unity .cache dir, I'd just add there... i.e. cachedir/unity/dashlegalseen

68 + QueueRelayout();
69 + QueueDraw();

The first is enough, as does also redraw.

64 + info_icon_->SetVisible(info_previously_shown_);
65 + legal_->SetVisible(!info_previously_shown_);
67 + DoOpenLegalise();

Wouldn't be better to open the legalise (and close the dash) and then switch the icon visibility?

95 + std::string legal_file_path = "file://";
96 + legal_file_path.append(PKGDATADIR);
97 + legal_file_path.append("/searchingthedashlegalnotice.html");

Why not just doing:
std::string legal_file_path = "file://" PKGDATADIR "/searchingthedashlegalnotice.html";

221 + nux::LayeredLayout* layered_layout_;
222 + nux::HLayout *legal_layout_;

It seems you don't need to keep these in class.

Finally, both the icon and the text are always built, only their visibility is switched, couldn't avoid this (and then only allocate only the needed resources)?

143 + auto geo = GetAbsoluteGeometry();

Ah, use auto const& instead ;)

> Looks good and works well...
>
> 29 + glib::String cachedir(g_strdup(g_get_user_cache_dir()));
>
> No need to strdup it, just assign that to std::string... It should be never
> NULL, in case just check for that.
>
> 30 + legal_seen_file_path_ = cachedir.Str() + "/unitydashlegalseen";
>
> Since we have an unity .cache dir, I'd just add there... i.e.
> cachedir/unity/dashlegalseen

we don't have a unity cache directory, not anymore.

>
> 68 + QueueRelayout();
> 69 + QueueDraw();
>
> The first is enough, as does also redraw.
>
> 64 + info_icon_->SetVisible(info_previously_shown_);
> 65 + legal_->SetVisible(!info_previously_shown_);
> 67 + DoOpenLegalise();
>
> Wouldn't be better to open the legalise (and close the dash) and then switch
> the icon visibility?
>
> 95 + std::string legal_file_path = "file://";
> 96 + legal_file_path.append(PKGDATADIR);
> 97 + legal_file_path.append("/searchingthedashlegalnotice.html");
>
> Why not just doing:
> std::string legal_file_path = "file://" PKGDATADIR
> "/searchingthedashlegalnotice.html";

personal preference

>
> 221 + nux::LayeredLayout* layered_layout_;
> 222 + nux::HLayout *legal_layout_;
>
> It seems you don't need to keep these in class.
>
> Finally, both the icon and the text are always built, only their visibility is
> switched, couldn't avoid this (and then only allocate only the needed
> resources)?

they could, but there is little reason to, its less than 2kb of memory.

This has been in 6.0 series already for some time (in this final form), would be good to have in lp:unity as well?

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/114/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/114/console

Gord, can you please merge with lp:unity and then re-upload your branch? The above is a jenkins error but it is a bit of corner case and left-over from the migration to inline packaging. Instead of creating some weird hack it would be easier to manually get the packaging into your branch (by merging with trunk). Many thanks!