Merge lp://qastaging/~gordallott/unity/fix-hud-refresh-move-selection into lp://qastaging/unity

Proposed by Gord Allott
Status: Merged
Approved by: Michal Hruby
Approved revision: no longer in the source branch.
Merged at revision: 2274
Proposed branch: lp://qastaging/~gordallott/unity/fix-hud-refresh-move-selection
Merge into: lp://qastaging/unity
Diff against target: 52 lines (+24/-0)
2 files modified
plugins/unityshell/src/HudView.cpp (+14/-0)
tests/autopilot/autopilot/tests/test_hud.py (+10/-0)
To merge this branch: bzr merge lp://qastaging/~gordallott/unity/fix-hud-refresh-move-selection
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+101579@code.qastaging.launchpad.net

Commit message

HUD: Ignores service updates if user is key navigating

Description of the change

Problem:
Hud resets its focus when it gets an updated query, the service likes to send these all the time, causing your selection to be reset when you are keynavigating

Solution:
ignore service updates when you are key navigating, which is better than the alternative of changing the buttons underneath the user

Testing:
yup

UNBLOCK

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

(UNBLOCKing as it's something a lot of people reported in the community test. We definitively want it for the release)

Revision history for this message
Michal Hruby (mhr3) wrote :

Looks reasonable. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.