Unity

Merge lp://qastaging/~gordallott/unity/fix-lp-878015 into lp://qastaging/unity

  1. fix-lp-878015
  2. Merge into trunk
Proposed by Gord Allott
Status: Merged
Approved by: Mirco Müller
Approved revision: no longer in the source branch.
Merged at revision: 2227
Proposed branch: lp://qastaging/~gordallott/unity/fix-lp-878015
Merge into: lp://qastaging/unity
Diff against target: 191 lines (+57/-24)
3 files modified
plugins/unityshell/src/ResultRendererTile.cpp (+51/-23)
plugins/unityshell/src/ResultRendererTile.h (+2/-1)
standalone-clients/CMakeLists.txt (+4/-0)
To merge this branch: bzr merge lp://qastaging/~gordallott/unity/fix-lp-878015
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+100953@code.qastaging.launchpad.net

Commit message

fixes widescreen icons being too small, makes them the correct aspect ratio and size

Description of the change

Small change to the dash tile visuals, fixes widescreen icons being too small, makes them the correct aspect ratio and size

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

In plugins/unityshell/src/ResultRendererTile.h:92 there a trailing double semicolon:

 int max_icon_width_;;

Also the vertical positioning is off (for the highlight) for aspect-ratios greater then 1.0... have a look at the provided screenshots:

http://people.canonical.com/~mmueller/fix-878015-issue-1.png
http://people.canonical.com/~mmueller/fix-878015-issue-2.png

review: Needs Fixing
Revision history for this message
Mirco Müller (macslow) wrote :

Check the highlighted and non-highlighted states of the file launcher_corner_h_tile_mask.png (middle PlacesGroup).

Revision history for this message
Mirco Müller (macslow) wrote :

All good now... approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.