Unity

Merge lp://qastaging/~gordallott/unity/fix-missing-icons into lp://qastaging/unity

  1. fix-missing-icons
  2. Merge into trunk
Proposed by Gord Allott
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1558
Proposed branch: lp://qastaging/~gordallott/unity/fix-missing-icons
Merge into: lp://qastaging/unity
Diff against target: 50 lines (+14/-5)
2 files modified
plugins/unityshell/src/IconLoader.cpp (+1/-0)
plugins/unityshell/src/ResultRendererTile.cpp (+13/-5)
To merge this branch: bzr merge lp://qastaging/~gordallott/unity/fix-missing-icons
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+74973@code.qastaging.launchpad.net

Description of the change

fix for lp:830887 hopefully

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Gord, afaics this introduces an new stat() call *every time* we load an icon - even if we've already cached it in the icon loader.

review: Needs Fixing
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I'd propose fixing the icon loader - also taking into account that the icon loader can cache the fact that a file doesn't exist. I've done similarly with .desktop files in libunity's Unity.AppInfoManager.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

r1529 discussed on irc

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.