Merge lp://qastaging/~gordallott/unity/fix-reflections into lp://qastaging/unity
Proposed by
Gord Allott
| Status: | Merged |
|---|---|
| Merged at revision: | 1608 |
| Proposed branch: | lp://qastaging/~gordallott/unity/fix-reflections |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
144 lines (+37/-12) 5 files modified
plugins/unityshell/src/DashView.cpp (+7/-5) plugins/unityshell/src/ResultViewGrid.cpp (+19/-7) plugins/unityshell/src/ResultViewGrid.h (+6/-0) plugins/unityshell/src/UBusMessages.h (+2/-0) tests/CMakeLists.txt (+3/-0) |
| To merge this branch: | bzr merge lp://qastaging/~gordallott/unity/fix-reflections |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
| Andrea Cimitan (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
fixes the dash reflections, they were based on the basewindow size but at some point the basewindow size got increased to the size of the maximised dash at all times, which threw the reflections off.
this is a crappy way to fix this, we'll need something better in P
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Coding wise, I can't see anything wrong. If the math and the threshold you're using to calculate the offset are right, that's a +1 from me.