Unity

manual-tests/Dash.txt (+13/-0)
plugins/unityshell/src/PlacesGroup.cpp (+16/-2)
plugins/unityshell/src/PlacesGroup.h (+2/-1)
plugins/unityshell/src/ResultView.h (+2/-0)
plugins/unityshell/src/ResultViewGrid.cpp (+1/-1)
standalone-clients/CMakeLists.txt (+4/-0)

To merge this branch:

bzr merge lp://qastaging/~gordallott/unity/fix-wrong-horizontal-see-more-size

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mirco Müller (community)			Approve on 2012-03-21
Alex Launi (community)			Needs Fixing on 2012-03-14
Gord Allott			Pending
Review via email: mp+96161@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-03-06.

Commit message

Fixes the incorrect item count in See x more results. see lp:934944

Description of the change

Fixes the attached bug, manual test supplied has instructions to test

No automatic test until I can figure out a nice way of doing it,
Feels like we need to run the AP tests with fake lenses to control the dash content
Which is entirely out of scope for this merge

Revision history for this message

Alex Launi (alexlauni) wrote on 2012-03-14:

15 +#. Open the dash, navigate to a lens that uses a horizontal renderer

give an example. don't expect testers to know the code base this well. Say "open the ____ lens"

Secondly. AUTOMATE THIS. This one is super easy to automate. You're just counting!

review: Needs Fixing

Revision history for this message

Alex Launi (alexlauni) wrote on 2012-03-14:

But you're right. Being able to control dash content would be an ace feature. Something that is really needed.

Revision history for this message

Gord Allott (gordallott) wrote on 2012-03-19:

> 15 +#. Open the dash, navigate to a lens that uses a horizontal renderer
>
> give an example. don't expect testers to know the code base this well. Say
> "open the ____ lens"
>
>
> Secondly. AUTOMATE THIS. This one is super easy to automate. You're just
> counting!

The issue really is that i'm not confident that i can say this lens will definately, 100% of the time, have enough content to run the test, which is why i'm saying we need to run our ap tests with fake lenses that provide what we need before I'm really confident enough to automate this

Revision history for this message

Mirco Müller (macslow) wrote on 2012-03-21:

Code look fine, but I can't verify its correct functioning with the described manual-test. With the music lens I always get one item more (in the expanded result-view) than the "see x more" + visible items (collapsed result-view).

review: Needs Fixing

Revision history for this message

Mirco Müller (macslow) wrote on 2012-03-21:

Now the number of items correctly adds up... with the filters being expanded or not. Approved.

review: Approve

Revision history for this message

Unity Merger (unity-merger) wrote on 2012-03-21:

No proposals found for merge of lp:~gordallott/unity/fix-standalone-dash-client-build into lp:unity.