Unity

Merge lp://qastaging/~gordallott/unity/hud-resizing into lp://qastaging/unity

  1. hud-resizing
  2. Merge into trunk
Proposed by Gord Allott
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1949
Proposed branch: lp://qastaging/~gordallott/unity/hud-resizing
Merge into: lp://qastaging/unity
Diff against target: 327 lines (+159/-44)
4 files modified
plugins/unityshell/src/HudController.cpp (+7/-2)
plugins/unityshell/src/HudView.cpp (+143/-41)
plugins/unityshell/src/HudView.h (+8/-0)
standalone-clients/StandaloneHud.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~gordallott/unity/hud-resizing
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Gord Allott (community) Approve
Review via email: mp+92527@code.qastaging.launchpad.net

Description of the change

Allows the hud to resize dynamically

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+ int target_height = content_layout_->GetGeometry().height;

Can you just use GetBaseHeight()? I know that GetGeometry return a const reference but it should be better...

---

nux::Geometry draw_content_geo = layout_->GetGeometry();

Please do something like this

nux::Geometry draw_content_geo(layout_->GetGeometry());

review: Needs Fixing
Revision history for this message
Gord Allott (gordallott) wrote :

Don't want to block on andyrock before freeze, made the change he requested so approving myself

review: Approve
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.