Merge lp://qastaging/~gordallott/unity/hud-wait-100ms into lp://qastaging/unity

Proposed by Gord Allott
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2203
Proposed branch: lp://qastaging/~gordallott/unity/hud-wait-100ms
Merge into: lp://qastaging/unity
Diff against target: 54 lines (+19/-1)
2 files modified
plugins/unityshell/src/HudController.cpp (+17/-1)
plugins/unityshell/src/HudController.h (+2/-0)
To merge this branch: bzr merge lp://qastaging/~gordallott/unity/hud-wait-100ms
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+99775@code.qastaging.launchpad.net

Commit message

Reduce stress on hud service by waiting 100ms prior to sending request.

Description of the change

helps reduce the stress on the service, request from desrt, only sends a new hud dbus query after waiting 100ms from the last typed letter

helps fix lp:948820

no testing as this is a stop gap fix and not the "correct" behaviour, if i were to write a test it would be to make a failing test so remind everyone to correct this bug properly
but we aren't allowed failing tests so oh well ;)

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

gord, can you put a big insulting FIXME as a comment maybe? ;)

Revision history for this message
Tim Penhey (thumper) wrote :

+1 with the FIXME comment.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.