Merge lp://qastaging/~gordallott/unity/keynav-fixes-11-03-10 into lp://qastaging/unity
Proposed by
Gord Allott
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 943 | ||||
| Proposed branch: | lp://qastaging/~gordallott/unity/keynav-fixes-11-03-10 | ||||
| Merge into: | lp://qastaging/unity | ||||
| Prerequisite: | lp://qastaging/~unity-team/unity/various-fixes-2011-03-08 | ||||
| Diff against target: |
454 lines (+120/-34) 14 files modified
src/IconTexture.cpp (+2/-1) src/IconTexture.h (+2/-3) src/PlacesGroup.cpp (+60/-13) src/PlacesGroup.h (+4/-0) src/PlacesResultsView.cpp (+19/-0) src/PlacesResultsView.h (+2/-0) src/PlacesSearchBar.cpp (+4/-6) src/PlacesSearchBar.h (+0/-2) src/PlacesTile.cpp (+7/-0) src/PlacesTile.h (+2/-2) src/PlacesView.cpp (+15/-1) src/StaticCairoText.cpp (+1/-5) src/StaticCairoText.h (+0/-1) tests/TestPlaces.cpp (+2/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~gordallott/unity/keynav-fixes-11-03-10 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Bunch of keynav fixes - still a few issues;
Can't click to focus the search bar anymore, not sure why, but as a consequence you don't get a cursor
when keynav is used on a group that has more items than are visible, you can navigate "into" that group, effectively losing focus on your keynav - should be fixed once groups are updated to not create more items than they can fit or groups at least make the items return false on IsVisible (); - unity bug not a keynav one
Keynav doesn't scroll the window
Combo-box isn't supported so you can't keynav to that yet.
requires https:/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Very, very cool, works well and we can fix the remaining things for next week. Approved.