Unity

Merge lp://qastaging/~gordallott/unity/newbg into lp://qastaging/unity

newbg
Merge into trunk

Proposed by Gord Allott on 2012-09-13

Status:

Merged

Approved by:

Omer Akram on 2012-09-14

Approved revision:

no longer in the source branch.

Merged at revision:

2692

Proposed branch:

lp://qastaging/~gordallott/unity/newbg

Merge into:

lp://qastaging/unity

Diff against target:

1047 lines (+462/-82)

17 files modified

dash/FilterBar.cpp (+0/-22)
dash/FilterBar.h (+0/-1)
dash/LensView.cpp (+30/-2)
dash/LensView.h (+1/-0)
dash/PlacesGroup.cpp (+85/-22)
dash/PlacesGroup.h (+5/-3)
panel/PanelController.cpp (+14/-0)
panel/PanelController.h (+2/-0)
panel/PanelView.cpp (+146/-2)
panel/PanelView.h (+11/-0)
panel/StandalonePanel.cpp (+8/-6)
plugins/unityshell/src/unityshell.cpp (+1/-0)
unity-shared/DashStyle.cpp (+37/-0)
unity-shared/DashStyle.h (+8/-1)
unity-shared/OverlayRenderer.cpp (+108/-22)
unity-shared/UBusMessages.h (+3/-0)
unity-standalone/StandaloneUnity.cpp (+3/-1)

To merge this branch:

bzr merge lp://qastaging/~gordallott/unity/newbg

Critical

Fix Released

Link a bug report

Related blueprints:

Ability to control Dash and Launcher opacity in CompizConfig Settings Manager (Undefined)

Reviewer	Review Type	Status
Omer Akram (community)		Approve on 2012-09-14
Andrea Azzarone (community)		Approve on 2012-09-14
John Lea (community)	design	Approve on 2012-09-14
Gord Allott		Pending
Review via email: mp+124241@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-09-13.

Commit message

Adds a new background gradient to the dash and panel, as well as removes some separator lines

Description of the change

Adds a new background gradient to the dash and panel, as well as removes some separator lines
Design request, visual changes, no tests

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2012-09-13:

Can you link the bugs to the MP?

review: Needs Information

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2012-09-13:

+ group->SetMinimumWidth(GetGeometry().width+20);

Use GetBaseWidth. Plase remove magic number too :)

+ scroll_layout_->GetGeometry().height > scroll_view_->GetGeometry().height

Use GetBaseGeometryHeight here too.

+ SetMinimumWidth(2000);

Remove this magic number too.

+ else if (g_strcmp0(renderer_name, "tile-vertical"))

Maybe I'm wrong, but are you sure that you don't need to check that g_strcmp(...) is == 0?

nux::TexCoordXForm texxform;
226 + if (_n_visible_items_in_unexpand_mode < 6 && _using_nofilters_background)
227 + {

Move 6 in a variable or something like that. Also rename _n_visible_items_in_unexpand_mode and _using_nofilters_background using the new style for the private members (variable_).

228 + _background_layer.reset(new nux::TextureLayer(_background->GetDeviceTexture(),
229 + texxform,
230 + nux::color::White,
231 + false,
232 + rop));

Also fix the indentation.

+ bg_geo.width = std::min(bg_width, bg_geo.GetWidth()) + 10;

Remove magic number.

+ //_queued_draw = false;

Remove this line if we no longer need it.

+ for (auto window: windows_)

I think you can use auto const& window : windows_ here.

review: Needs Fixing

Revision history for this message

Omer Akram (om26er) wrote on 2012-09-13:

Unity is crashing for me with this branch: http://fpaste.org/VcFL/raw/

Revision history for this message

Gord Allott (gordallott) wrote on 2012-09-14:

> Move 6 in a variable or something like that. Also rename
> _n_visible_items_in_unexpand_mode and _using_nofilters_background using the
> new style for the private members (variable_).

the rest of the file doesn't follow that convention, the file style overrides the new style and i'm not going to change the entire thing in this mp

Revision history for this message

Gord Allott (gordallott) wrote on 2012-09-14:

> Unity is crashing for me with this branch: http://fpaste.org/VcFL/raw/

don't use fedoras pastebin, its a giant pain, has captchas just to view

it looks like you don't have refine_gradient_panel_single_column.png installed. crashes are expected if you don't have the required resources