Merge lp://qastaging/~gpiccoli/britney/hints-ubuntu-disco into lp://qastaging/~ubuntu-sru/britney/hints-ubuntu-disco
Proposed by
Guilherme G. Piccoli
| Status: | Merged |
|---|---|
| Merged at revision: | 3714 |
| Proposed branch: | lp://qastaging/~gpiccoli/britney/hints-ubuntu-disco |
| Merge into: | lp://qastaging/~ubuntu-sru/britney/hints-ubuntu-disco |
| Diff against target: |
12 lines (+5/-0) 1 file modified
ubuntu-sru (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~gpiccoli/britney/hints-ubuntu-disco |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Łukasz Zemczak | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Guilherme G. Piccoli (gpiccoli) wrote | # |
Revision history for this message
| Łukasz Zemczak (sil2100) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 on hinting the packages, but -1 on adding an unversioned hint. Unversioned hints should be only added in cases where we know that either the tests will never work or that, for some well identified reasons, we know we don't want to block on those. In this case however it is an infrastructure issue that we're still investigating and, hopefully, we'll try resolving in the nearest time. Unversioned hints are easy to forget, reducing our test capabilities.
Could you modify the hint to use the latest version instead of 'all'? Thank you!