Merge lp://qastaging/~gthorslund/bzr-bisect/539937-subtree into lp://qastaging/bzr-bisect
Proposed by
Gustaf Thorslund
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Jelmer Vernooij | ||||
| Approved revision: | 81 | ||||
| Merged at revision: | 78 | ||||
| Proposed branch: | lp://qastaging/~gthorslund/bzr-bisect/539937-subtree | ||||
| Merge into: | lp://qastaging/bzr-bisect | ||||
| Diff against target: |
578 lines (+129/-60) 3 files modified
__init__.py (+35/-35) meta.py (+1/-1) tests.py (+93/-24) |
||||
| To merge this branch: | bzr merge lp://qastaging/~gthorslund/bzr-bisect/539937-subtree | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Added three test cases. Two of them will still fail due to:
https:/
marked them as KnownFailure.
To post a comment you must log in.
Revision history for this message
| Jelmer Vernooij (jelmer) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks! It's nice to have some tests for these bugs, that should make them a lot easier to fix.
For consistency, can you change the syntax of the docstrings to use """ rather than " ?
The script tests probably won't work on Windows at the moment. I wonder if this is an issue for bzr-bisect (did it work on Windows before?). Ideally we should make these tests work on Windows as well, though for the moment it is probably sufficient to check sys.platform and raise TestSkipped if sys.platform is "win32".