Midori Web Browser

Merge lp://qastaging/~gue5t/midori/bookmark-bar-click into lp://qastaging/midori

  1. bookmark-bar-click
  2. Merge into trunk
Proposed by gue5t gue5t
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6983
Merged at revision: 6993
Proposed branch: lp://qastaging/~gue5t/midori/bookmark-bar-click
Merge into: lp://qastaging/midori
Diff against target: 86 lines (+41/-8)
1 file modified
katze/katze-arrayaction.c (+41/-8)
To merge this branch: bzr merge lp://qastaging/~gue5t/midori/bookmark-bar-click
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+263421@code.qastaging.launchpad.net

Commit message

Fix middle/ctrl/normal clicking bookmarks (not folders) in the bookmarkbar.

Description of the change

http://bazaar.launchpad.net/~midori/midori/trunk/revision/6906 cleaned up KatzeArrayAction events, in particular making sure the right events were dispatched on button press vs. release for menuitems. However I neglected to consider the effect of these changes on the bookmarkbar, which was written to open bookmarks on button-press.

So middle/ctr/normal clicks on bookmarkbar entries which were not folders no longer did anything.

This patch fixes bookmarkbar entries to open on button-release as is expected in GTK user interfaces, and adds several comments explaining the implementation details.

To post a comment you must log in.
lp://qastaging/~gue5t/midori/bookmark-bar-click updated
6983. By gue5t <email address hidden>

make katze_array_action_tool_item_child_button_release_cb more careful about return value

Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: