Merge lp://qastaging/~gue5t/midori/bookmark-search-gtk2-placeholder into lp://qastaging/midori

Proposed by gue5t gue5t
Status: Merged
Approved by: Cris Dywan
Approved revision: 7013
Merged at revision: 7014
Proposed branch: lp://qastaging/~gue5t/midori/bookmark-search-gtk2-placeholder
Merge into: lp://qastaging/midori
Diff against target: 25 lines (+2/-2)
2 files modified
panels/midori-bookmarks.c (+1/-1)
panels/midori-history.c (+1/-1)
To merge this branch: bzr merge lp://qastaging/~gue5t/midori/bookmark-search-gtk2-placeholder
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+267465@code.qastaging.launchpad.net

Commit message

Fix fallout (broken bookmarks and history panel search) from tweaks to GTK2 entry placeholder

Description of the change

Two places were passing the wrong key to g_object_set_data to check whether the search entry was showing a placeholder. This fixes them and makes search of bookmarks and history in the respective panels work properly again.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Another good catch! So apparently that wasn't renamed when sokoke-has-default was renamed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: