Merge lp://qastaging/~gue5t/midori/last-placeholders into lp://qastaging/midori
Proposed by
gue5t gue5t
| Status: | Merged |
|---|---|
| Approved by: | Cris Dywan |
| Approved revision: | 7017 |
| Merged at revision: | 7021 |
| Proposed branch: | lp://qastaging/~gue5t/midori/last-placeholders |
| Merge into: | lp://qastaging/midori |
| Diff against target: |
106 lines (+38/-6) 3 files modified
extensions/cookie-manager/cookie-manager-page.c (+3/-3) katze/gtk3-compat.c (+31/-2) midori/midori-locationaction.c (+4/-1) |
| To merge this branch: | bzr merge lp://qastaging/~gue5t/midori/last-placeholders |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cris Dywan | Approve | ||
|
Review via email:
|
|||
Commit message
Fix last known GTK2 entry placeholder text bugs
Description of the change
This branch fixes the last bugs I could find with GTK2 entry placeholder text. One is that cookie permissions was still using the old string to check placeholder visibility, but this branch also ensures that signal handlers for placeholder maintenance are removed when setting a NULL placeholder and makes right-click paste work properly.
To post a comment you must log in.
Revision history for this message
| Cris Dywan (kalikiana) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Maybe we should have some #define or utility function like sokoke_