Merge lp://qastaging/~gz/bzr-svn/unicode_password_prompt_1076386 into lp://qastaging/bzr-svn
Proposed by
Martin Packman
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 4196 | ||||
| Proposed branch: | lp://qastaging/~gz/bzr-svn/unicode_password_prompt_1076386 | ||||
| Merge into: | lp://qastaging/bzr-svn | ||||
| Diff against target: |
93 lines (+55/-1) 4 files modified
NEWS (+3/-0) auth.py (+1/-1) tests/__init__.py (+1/-0) tests/test_auth.py (+50/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~gz/bzr-svn/unicode_password_prompt_1076386 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Fix prompting for passwords against newer bzr versions which have become strict about ui-level strings actually being unicode rather than bytestrings. Core bzr should possibly make allowances for old plugins that are lax about this, but since at least 2.2 TextUIFactory.
The branch also adds a new tests.test_auth module as the current auth module seems to be untested at present.
To post a comment you must log in.
Revision history for this message
| Martin Packman (gz) wrote | # |
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, please land. :-) Can you add an entry in NEWS as well?