Merge lp://qastaging/~gz/launchpad/root_blog_feature_flag_939055 into lp://qastaging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Martin Packman |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 15805 |
| Proposed branch: | lp://qastaging/~gz/launchpad/root_blog_feature_flag_939055 |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
194 lines (+90/-8) 5 files modified
lib/lp/app/browser/root.py (+9/-0) lib/lp/app/browser/tests/test_launchpadroot.py (+64/-0) lib/lp/app/stories/launchpad-root/front-pages.txt (+4/-2) lib/lp/app/templates/root-index.pt (+7/-6) lib/lp/services/features/flags.py (+6/-0) |
| To merge this branch: | bzr merge lp://qastaging/~gz/launchpad/root_blog_feature_flag_939055 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Only display posts from the launchpad blog on the main page when the new app.root_
This is something of an abuse of the feature flags... feature, but Robert suggested it as the easiest method in the bug.
To prevent gaping whitespace in the left column, the logic for whether or not to display the launchpad introduction is adapted from always being off for logged in users to being on regardless if the blog isn't being shown.
The tests added are not exhaustive as they're expensive at this level, but should cover the details we care about.
= LOC =
I have some credit to burn...
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
| Martin Packman (gz) wrote | # |
The branch looks good.
The boolean expression in show_whatslaunchpad is sufficiently complex
that a comment giving the prose translation (as well as the motivation
for including the "what is" section when the blog is disabled) would be
a good idea.