Merge lp://qastaging/~gz/pyjuju/os_scheduler_hints_json_fix into lp://qastaging/pyjuju

Proposed by Martin Packman
Status: Merged
Approved by: Kapil Thangavelu
Approved revision: 617
Merged at revision: 617
Proposed branch: lp://qastaging/~gz/pyjuju/os_scheduler_hints_json_fix
Merge into: lp://qastaging/pyjuju
Diff against target: 37 lines (+6/-4)
2 files modified
juju/providers/openstack/client.py (+3/-2)
juju/providers/openstack/tests/test_client.py (+3/-2)
To merge this branch: bzr merge lp://qastaging/~gz/pyjuju/os_scheduler_hints_json_fix
Reviewer Review Type Date Requested Status
Kapil Thangavelu (community) Approve
John A Meinel Approve
Review via email: mp+149028@code.qastaging.launchpad.net

Description of the change

Fix format of the scheduler hints passed in the json dict when creating a server.

This is the juju part of getting hints working, see the mailing list post:

<https://lists.ubuntu.com/archives/juju/2013-February/002112.html>

There is some discussion about designing a neater abstraction, this is just fixing the existing code in the interim.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

Matches my understanding of how this should work.

review: Approve
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: