Merge lp://qastaging/~hatch/juju-gui/parse-pending-types into lp://qastaging/juju-gui/experimental

Proposed by Jeff Pihach
Status: Merged
Merged at revision: 1217
Proposed branch: lp://qastaging/~hatch/juju-gui/parse-pending-types
Merge into: lp://qastaging/juju-gui/experimental
Diff against target: 282 lines (+52/-71)
9 files modified
app/models/handlers.js (+4/-1)
app/models/models.js (+16/-17)
app/store/env/simulator.js (+2/-12)
app/views/environment.js (+2/-23)
app/views/inspector.js (+1/-1)
app/views/utils.js (+15/-7)
app/views/viewlets/service-overview.js (+6/-4)
test/test_model.js (+5/-5)
test/test_service_module.js (+1/-1)
To merge this branch: bzr merge lp://qastaging/~hatch/juju-gui/parse-pending-types
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+197441@code.qastaging.launchpad.net

Description of the change

Adds pending and dying statuses to the inspector

A service in various states of pending are now properly represented in the
inspector.

Dying services are now left on the canvas with their inspectors until the service
is entirely destroyed from Juju.

https://codereview.appspot.com/36240043/

To post a comment you must log in.
Revision history for this message
Jeff Pihach (hatch) wrote :

Reviewers: mp+197441_code.launchpad.net,

Message:
Please take a look.

Description:
Adds pending and dying statuses to the inspector

A service in various states of pending are now properly represented in
the
inspector.

Dying services are now left on the canvas with their inspectors until
the service
is entirely destroyed from Juju.

To QA:
Sandbox:
Deploy some services and make sure you can destroy them in various ways.
Deploy a service with a lot of units and wait for the simulator to show
   pending and installing statuses

Real Env:
Deploy 4 instances of failtester
Set one to fail on install hook
Open one of the pending services inspectors and then delete it from the
console
It should enter a 'dying' state then remove from the canvas when
finished
Wait for the remaining failtester services to come green/red
Destroy one from the GUI, it should enter a 'dying' state and then
remove from the canvas
   closing the inspector when it's done.
Open the other green one, destroy it from the console, it should enter a
'dying' state and
   then remove from the canvas
Open the red one's inspector, destroy it from the console, nothing
should happen in the GUI
Resolve the unit in error in the GUI and the service should enter a
'dying' state then
   remove from the canvas when done.

https://code.launchpad.net/~hatch/juju-gui/parse-pending-types/+merge/197441

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/36240043/

Affected files (+54, -71 lines):
   A [revision details]
   M app/models/handlers.js
   M app/models/models.js
   M app/store/env/simulator.js
   M app/views/environment.js
   M app/views/inspector.js
   M app/views/utils.js
   M app/views/viewlets/service-overview.js
   M test/test_model.js
   M test/test_service_module.js

Revision history for this message
Madison Scott-Clary (makyo) wrote :

LGTM, QA okay, one question, feel free to say no! Thanks.

https://codereview.appspot.com/36240043/diff/1/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/36240043/diff/1/app/models/models.js#newcode205
app/models/models.js:205: if (life === ALIVE || life === 'dying') {
We have a constant ALIVE, might it make sense to do he samefor DYING?

https://codereview.appspot.com/36240043/

Revision history for this message
Jeff Pihach (hatch) wrote :

*** Submitted:

Adds pending and dying statuses to the inspector

A service in various states of pending are now properly represented in
the
inspector.

Dying services are now left on the canvas with their inspectors until
the service
is entirely destroyed from Juju.

R=matthew.scott
CC=
https://codereview.appspot.com/36240043

https://codereview.appspot.com/36240043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches