Merge lp://qastaging/~hatch/juju-gui/parse-pending-types into lp://qastaging/juju-gui/experimental
Proposed by
Jeff Pihach
Status: | Merged |
---|---|
Merged at revision: | 1217 |
Proposed branch: | lp://qastaging/~hatch/juju-gui/parse-pending-types |
Merge into: | lp://qastaging/juju-gui/experimental |
Diff against target: |
282 lines (+52/-71) 9 files modified
app/models/handlers.js (+4/-1) app/models/models.js (+16/-17) app/store/env/simulator.js (+2/-12) app/views/environment.js (+2/-23) app/views/inspector.js (+1/-1) app/views/utils.js (+15/-7) app/views/viewlets/service-overview.js (+6/-4) test/test_model.js (+5/-5) test/test_service_module.js (+1/-1) |
To merge this branch: | bzr merge lp://qastaging/~hatch/juju-gui/parse-pending-types |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email:
|
Description of the change
Adds pending and dying statuses to the inspector
A service in various states of pending are now properly represented in the
inspector.
Dying services are now left on the canvas with their inspectors until the service
is entirely destroyed from Juju.
To post a comment you must log in.
Reviewers: mp+197441_ code.launchpad. net,
Message:
Please take a look.
Description:
Adds pending and dying statuses to the inspector
A service in various states of pending are now properly represented in
the
inspector.
Dying services are now left on the canvas with their inspectors until
the service
is entirely destroyed from Juju.
To QA:
Sandbox:
Deploy some services and make sure you can destroy them in various ways.
Deploy a service with a lot of units and wait for the simulator to show
pending and installing statuses
Real Env:
Deploy 4 instances of failtester
Set one to fail on install hook
Open one of the pending services inspectors and then delete it from the
console
It should enter a 'dying' state then remove from the canvas when
finished
Wait for the remaining failtester services to come green/red
Destroy one from the GUI, it should enter a 'dying' state and then
remove from the canvas
closing the inspector when it's done.
Open the other green one, destroy it from the console, it should enter a
'dying' state and
then remove from the canvas
Open the red one's inspector, destroy it from the console, nothing
should happen in the GUI
Resolve the unit in error in the GUI and the service should enter a
'dying' state then
remove from the canvas when done.
https:/ /code.launchpad .net/~hatch/ juju-gui/ parse-pending- types/+ merge/197441
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/36240043/
Affected files (+54, -71 lines): handlers. js models. js env/simulator. js environment. js inspector. js viewlets/ service- overview. js service_ module. js
A [revision details]
M app/models/
M app/models/
M app/store/
M app/views/
M app/views/
M app/views/utils.js
M app/views/
M test/test_model.js
M test/test_