Merge lp://qastaging/~hazmat/pyjuju/twisted-precise-compat into lp://qastaging/pyjuju

Proposed by Kapil Thangavelu
Status: Merged
Approved by: Jim Baker
Approved revision: 444
Merged at revision: 444
Proposed branch: lp://qastaging/~hazmat/pyjuju/twisted-precise-compat
Merge into: lp://qastaging/pyjuju
Diff against target: 43 lines (+4/-4)
2 files modified
juju/providers/orchestra/digestauth.py (+1/-0)
juju/providers/orchestra/tests/test_digestauth.py (+3/-4)
To merge this branch: bzr merge lp://qastaging/~hazmat/pyjuju/twisted-precise-compat
Reviewer Review Type Date Requested Status
Jim Baker (community) Approve
William Reade (community) Approve
Review via email: mp+89490@code.qastaging.launchpad.net

Description of the change

Fix for twisted 11.1 compatiblity, fixes precise ppa builds

Twisted 11.1 introduced the notion of signalling for when a request is
completely done across multiple connections on the client deferred, to support
for example redirects returning the final contents of a page. The orchestra
provider auth integration needed a one liner to enable it to work with this
support. There were also some changes to the ssl/bio protocol for additional
buffering on close, but that's mostly immaterial here, just suppressed the
warning.

To post a comment you must log in.
Revision history for this message
William Reade (fwereade) wrote :

+1, LGTM. Well found...

review: Approve
Revision history for this message
Jim Baker (jimbaker) wrote :

+1, approved earlier on irc

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: