Merge lp://qastaging/~heut2008/charms/precise/nova-compute/add-boot-from-rbd into lp://qastaging/~openstack-charmers-archive/charms/precise/nova-compute/trunk

Proposed by Yaguang Tang
Status: Rejected
Rejected by: Edward Hope-Morley
Proposed branch: lp://qastaging/~heut2008/charms/precise/nova-compute/add-boot-from-rbd
Merge into: lp://qastaging/~openstack-charmers-archive/charms/precise/nova-compute/trunk
Diff against target: 36 lines (+10/-1)
2 files modified
hooks/nova_compute_context.py (+2/-0)
templates/havana/nova.conf (+8/-1)
To merge this branch: bzr merge lp://qastaging/~heut2008/charms/precise/nova-compute/add-boot-from-rbd
Reviewer Review Type Date Requested Status
Edward Hope-Morley Disapprove
OpenStack Charmers Pending
James Page Pending
Review via email: mp+210958@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :

This has not been tested yet. Yagunag, please remove WIP once it has been tested.

Revision history for this message
James Page (james-page) wrote :

One comment - this really needs to be gated on openstack release; I think only >= havana can use this and the charm supports right back to essex :-)

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Will resubmit new patchset once tested.

review: Disapprove

Unmerged revisions

57. By Yaguang Tang

Add an option boot_from_rbd for nova-compute so that instances can boot
from rbd directly.

56. By Yaguang Tang

Change rbd option in nova.conf from rbd_pool to libvirt_images_rbd_pool for Havana

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches