Merge lp://qastaging/~hiberis/intltool/silent-rules into lp://qastaging/intltool

Proposed by Hib Eris
Status: Merged
Merged at revision: 730
Proposed branch: lp://qastaging/~hiberis/intltool/silent-rules
Merge into: lp://qastaging/intltool
Diff against target: 103 lines (+46/-22)
2 files modified
Makefile.in.in (+7/-2)
intltool.m4 (+39/-20)
To merge this branch: bzr merge lp://qastaging/~hiberis/intltool/silent-rules
Reviewer Review Type Date Requested Status
Данило Шеган Approve
Review via email: mp+89076@code.qastaging.launchpad.net

Commit message

Add support for silent-rules

Description of the change

Automake has an option 'silent-rules'. It enable less verbose build rules. This can be used to let build rules output a status line of the form

 GEN output-file

instead of printing the command that will be executed to update output-file.

This branch adds support for silent-rules to intltool.m4 and makefile.in.in

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, thanks for working on this. I am slightly unhappy with the substitution variable names (eg. it'd be better if the INTLTOOL_V_merge indicated that it's for options, because that's only clear because of its value "-q" for V==0), but it's no big deal: I'll just rename INTLTOOL_V_merge to INTLTOOL_V_MERGE_OPTIONS so it is more clearly different from INTLTOOL_V_MERGE.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: