Merge lp://qastaging/~hikiko/compiz/compiz.clear-skydome-background into lp://qastaging/compiz/0.9.12
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | 3940 |
| Merged at revision: | 3941 |
| Proposed branch: | lp://qastaging/~hikiko/compiz/compiz.clear-skydome-background |
| Merge into: | lp://qastaging/compiz/0.9.12 |
| Prerequisite: | lp://qastaging/~hikiko/compiz/compiz.3d-plugin-fixes |
| Diff against target: |
11 lines (+1/-0) 1 file modified
plugins/cube/src/cube.cpp (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~hikiko/compiz/compiz.clear-skydome-background |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Trevisan (Treviño) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Minor change: when the skydome was working (in the c version of compiz) it was rendered on top of the background so, there was no need to clear the screen before drawing (the skydome was rendered on top of the garbage from previous renderings, hiding it). In the c++ plugin, the skydome is buggy and the background is visible (as well as some garbage from previous renderings). A temporary glClear(
Description of the change
Minor change: when the skydome was working (in the c version of compiz) it was rendered on top of the background so, there was no need to clear the screen before drawing (the skydome was rendered on top of the garbage from previous renderings, hiding it). In the c++ plugin, the skydome is buggy and the background is visible (as well as some garbage from previous renderings). A temporary glClear(
| Eleni Maria Stea (hikiko) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
screenshot before the fix: https:/
screenshot after the fix: https:/