Merge lp://qastaging/~hmiguellima/ubuntu-facebook-app/hlima-initial into lp://qastaging/ubuntu-facebook-app

Proposed by Hugo Miguel Barbarrica Rodrigues Lima
Status: Merged
Approved by: Michael Hall
Approved revision: 24
Merged at revision: 5
Proposed branch: lp://qastaging/~hmiguellima/ubuntu-facebook-app/hlima-initial
Merge into: lp://qastaging/ubuntu-facebook-app
Diff against target: 1558 lines (+1074/-63)
24 files modified
AuthModel.qml (+1/-0)
CommentsPanel.qml (+236/-0)
LoginPopup.qml (+3/-1)
NewsPage.qml (+46/-40)
StatusUpdatePopup.qml (+138/-0)
ThreadView.qml (+132/-0)
app-theme.qmltheme (+322/-0)
artwork/PageHeaderBaseDivider@18.sci (+5/-0)
artwork/PageHeaderBaseDividerLight@18.sci (+5/-0)
artwork/TabLeftSelected@8.sci (+7/-0)
artwork/TabLeftUnselected@8.sci (+7/-0)
artwork/TabMiddleSelected@8.sci (+7/-0)
artwork/TabMiddleUnselected@8.sci (+7/-0)
artwork/TabRightSelected@8.sci (+7/-0)
artwork/TabRightUnselected@8.sci (+7/-0)
artwork/ubuntushape_medium_radius_idle@18.sci (+5/-0)
artwork/ubuntushape_medium_radius_pressed@18.sci (+5/-0)
artwork/ubuntushape_medium_radius_shape@18.sci (+5/-0)
artwork/ubuntushape_small_radius_idle@18.sci (+5/-0)
artwork/ubuntushape_small_radius_pressed@18.sci (+5/-0)
artwork/ubuntushape_small_radius_shape@18.sci (+5/-0)
auth.js (+18/-13)
facebook.js (+49/-0)
ubuntu-facebook-app.qml (+47/-9)
To merge this branch: bzr merge lp://qastaging/~hmiguellima/ubuntu-facebook-app/hlima-initial
Reviewer Review Type Date Requested Status
Michael Hall Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+163079@code.qastaging.launchpad.net

Commit message

Initial development:

- List comments and likes
- Post a comment
- Like / Unlike post

Description of the change

Initial devel (comments and likes)

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:21
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~hmiguellima/ubuntu-facebook-app/hlima-initial/+merge/163079/+edit-commit-message

http://91.189.93.125:8080/job/ubuntu-facebook-app-ci/1/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-facebook-app-quantal-amd64-ci/1
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-facebook-app-raring-amd64-ci/1

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-facebook-app-ci/1/rebuild

review: Needs Fixing (continuous-integration)
22. By Hugo Miguel Barbarrica Rodrigues Lima

Header styling

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
23. By Hugo Miguel Barbarrica Rodrigues Lima

Status update component UI

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
24. By Hugo Miguel Barbarrica Rodrigues Lima

Send post (wall)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Hall (mhall119) wrote :

Tried it on my Nexus 7, looking pretty good, everything seems to work.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches