Merge lp://qastaging/~hopem/charm-helpers/retry-crm-resource-check-if-not-running into lp://qastaging/charm-helpers
Proposed by
Edward Hope-Morley
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~hopem/charm-helpers/retry-crm-resource-check-if-not-running |
| Merge into: | lp://qastaging/charm-helpers |
| Diff against target: |
173 lines (+90/-17) 3 files modified
charmhelpers/contrib/hahelpers/cluster.py (+27/-12) charmhelpers/core/decorators.py (+41/-0) tests/contrib/hahelpers/test_cluster_utils.py (+22/-5) |
| To merge this branch: | bzr merge lp://qastaging/~hopem/charm-helpers/retry-crm-resource-check-if-not-running |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jorge Niedbalski (community) | Needs Fixing | ||
| James Page | Pending | ||
| OpenStack Charmers | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-12-17.
To post a comment you must log in.
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nevertheless that corosync resource synchronization should be a pretty quick process, this workaround seems like a good addition for cases in which this is not happening quickly.
- Do you mind to move the nice retry_on_exception method to charmhelpers.
- I found a minor python 3 issue trying to decode a string. (commented)
Other than that LGTM.