Merge lp://qastaging/~hopem/charms/trusty/keystone/fix-db-access-before-ready-2 into lp://qastaging/~openstack-charmers-archive/charms/trusty/keystone/next

Proposed by Edward Hope-Morley
Status: Merged
Approved by: Billy Olsen
Approved revision: 134
Merged at revision: 133
Proposed branch: lp://qastaging/~hopem/charms/trusty/keystone/fix-db-access-before-ready-2
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/keystone/next
Diff against target: 36 lines (+12/-0)
2 files modified
hooks/keystone_utils.py (+5/-0)
unit_tests/test_keystone_utils.py (+7/-0)
To merge this branch: bzr merge lp://qastaging/~hopem/charms/trusty/keystone/fix-db-access-before-ready-2
Reviewer Review Type Date Requested Status
Billy Olsen Approve
OpenStack Charmers Pending
Review via email: mp+254322@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-03-26.

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote : Posted in a previous version of this proposal

Needs some unit test coverage

review: Needs Fixing
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches