Juju Charms Collection
neutron-api package

Merge lp://qastaging/~hopem/charms/trusty/neutron-api/add-configurable-flat-network into lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-api/next

  1. Trusty Tahr (14.04)
  2. add-configurable-flat-network
  3. Merge into next
Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 101
Proposed branch: lp://qastaging/~hopem/charms/trusty/neutron-api/add-configurable-flat-network
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-api/next
Diff against target: 90 lines (+14/-11)
3 files modified
config.yaml (+7/-1)
hooks/neutron_api_context.py (+5/-7)
unit_tests/test_neutron_api_context.py (+2/-3)
To merge this branch: bzr merge lp://qastaging/~hopem/charms/trusty/neutron-api/add-configurable-flat-network
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+256324@code.qastaging.launchpad.net
To post a comment you must log in.
lp://qastaging/~hopem/charms/trusty/neutron-api/add-configurable-flat-network updated
100. By Edward Hope-Morley

better desc

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3389 neutron-api-next for hopem mp256324
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3389/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3177 neutron-api-next for hopem mp256324
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3177/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3179 neutron-api-next for hopem mp256324
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/3179/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Code changes look fine to me but I can't get an instance to boot when deploying the changes. I suspect its probably me setting the value incorrectly, but I'd like independent verification.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Testing now.

Revision history for this message
Liam Young (gnuoy) wrote :

LGTM, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches