Merge lp://qastaging/~hopem/charms/trusty/neutron-api/charm-helpers-sync-precise-ipv6-haproxy into lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-api/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 67
Proposed branch: lp://qastaging/~hopem/charms/trusty/neutron-api/charm-helpers-sync-precise-ipv6-haproxy
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/neutron-api/next
Diff against target: 47 lines (+11/-2)
3 files modified
hooks/charmhelpers/contrib/openstack/context.py (+1/-0)
hooks/charmhelpers/contrib/openstack/neutron.py (+8/-2)
hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg (+2/-0)
To merge this branch: bzr merge lp://qastaging/~hopem/charms/trusty/neutron-api/charm-helpers-sync-precise-ipv6-haproxy
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Liam Young (community) Approve
Review via email: mp+245221@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #318 neutron-api-next for hopem mp245221
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/318/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #347 neutron-api-next for hopem mp245221
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/347/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #480 neutron-api-next for hopem mp245221
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/9571847/
Build: http://10.245.162.77:8080/job/charm_amulet_test/480/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

confirmed a-ok on p-i, t-i, t-j, u-j. thank you, all!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches