Merge lp://qastaging/~hopem/charms/trusty/percona-cluster/next-fix-lp1425999 into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

Proposed by Edward Hope-Morley
Status: Merged
Approved by: Billy Olsen
Approved revision: 51
Merged at revision: 51
Proposed branch: lp://qastaging/~hopem/charms/trusty/percona-cluster/next-fix-lp1425999
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 316 lines (+138/-64)
3 files modified
hooks/charmhelpers/contrib/database/mysql.py (+42/-59)
hooks/charmhelpers/contrib/network/ip.py (+84/-1)
hooks/charmhelpers/core/services/helpers.py (+12/-4)
To merge this branch: bzr merge lp://qastaging/~hopem/charms/trusty/percona-cluster/next-fix-lp1425999
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Jorge Niedbalski (community) Approve
Review via email: mp+251237@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-02-26.

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote : Posted in a previous version of this proposal

LGTM, Approved. Everything looks good to in my testing.

review: Approve
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Reverted and resynced to incorporate get_host_ip() from charmhelpers

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Thanks for the re-sync Ed.

LGTM +1

review: Approve
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches