Juju Charms Collection
quantum-gateway package

Merge lp://qastaging/~hopem/charms/trusty/quantum-gateway/add-configurable-flat-network into lp://qastaging/~openstack-charmers/charms/trusty/quantum-gateway/next

  1. Trusty Tahr (14.04)
  2. add-configurable-flat-network
  3. Merge into next
Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 99
Proposed branch: lp://qastaging/~hopem/charms/trusty/quantum-gateway/add-configurable-flat-network
Merge into: lp://qastaging/~openstack-charmers/charms/trusty/quantum-gateway/next
Diff against target: 74 lines (+14/-9)
3 files modified
config.yaml (+7/-1)
hooks/quantum_contexts.py (+5/-7)
unit_tests/test_quantum_contexts.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~hopem/charms/trusty/quantum-gateway/add-configurable-flat-network
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+256325@code.qastaging.launchpad.net
To post a comment you must log in.
lp://qastaging/~hopem/charms/trusty/quantum-gateway/add-configurable-flat-network updated
99. By Edward Hope-Morley

better desc

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3390 quantum-gateway-next for hopem mp256325
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3390/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3178 quantum-gateway-next for hopem mp256325
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3178/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3180 quantum-gateway-next for hopem mp256325
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/3180/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Code changes look fine to me but I can't get an instance to boot when deploying the changes. I suspect its probably me setting the value incorrectly, but I'd like independent verification.

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Testing now.

Revision history for this message
Liam Young (gnuoy) wrote :

LGTM, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches