Merge lp://qastaging/~hrvojem/percona-xtrabackup/rn-2.1.5-2.1 into lp://qastaging/percona-xtrabackup/2.1
Proposed by
Hrvoje Matijakovic
| Status: | Merged |
|---|---|
| Approved by: | Alexey Kopytov |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 678 |
| Proposed branch: | lp://qastaging/~hrvojem/percona-xtrabackup/rn-2.1.5-2.1 |
| Merge into: | lp://qastaging/percona-xtrabackup/2.1 |
| Diff against target: |
188 lines (+117/-3) 7 files modified
doc/source/conf.py (+2/-2) doc/source/innobackupex/innobackupex_option_reference.rst (+4/-0) doc/source/percona-theme/layout.html (+1/-1) doc/source/release-notes/2.1/2.1.5.rst (+32/-0) doc/source/xtrabackup_bin/incremental_backups_with_ps_56.rst (+69/-0) doc/source/xtrabackup_bin/xbk_option_reference.rst (+8/-0) doc/source/xtrabackup_bin/xtrabackup_binary.rst (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~hrvojem/percona-xtrabackup/rn-2.1.5-2.1 |
| Related bugs: | |
| Related blueprints: |
Document log archiving for XtraBackup
(Essential)
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexey Kopytov (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Alexey Kopytov (akopytov) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hrvoje,
- The following statement is contradictory: “ When this option is
specified, innobackupex will perform a version check against the
server on the backup stage after creating a server connection. This
option will provide the user with the information when certain
programs (Percona Toolkit tools, Percona XtraBackup, Perl, etc.) are
either out of date or are known bad versions.”
It does perform a version check against the (MySQL) server, but
nothing more than that currently (i.e. no checks against
PT/PXB/Perl, etc.)
- “|Percona XtraBackup| has implemented” => “|Percona XtraBackup| now
supports” ?
- the following is incorrect: “|Percona XtraBackup| didn't free File
Handlers when preparing the compact backups, which would lead to
disk space not being freed after the prepare process finished”
I suggest the following text: “|Percona XtraBackup| did not close
temporary files created when preparing a compact backup, which
would lead to excessive disk space usage until the prepare process
finished”
- “Depending on the subroutine |innobackupex| would sometimes” =>
“|innobackupex| could sometimes”
- “which did not respect the :option:
anymore and used the ``cp -R`` instead” =>
“which lead to ``cp`` utility being used to copy metadata files even
if the :option:
- the following statements are incorrect: “When log archiving is
enabled, instead of rotating through log files, |XtraDB| will create
a new one. There will always be one spare log file so that
transactions are never stalled at log file rotation.” (also reported
as server doc bug #1227611)