PulseAudio

Merge lp://qastaging/~hyperair/pulseaudio/fix-01Pulseaudio-quoting into lp://qastaging/~ubuntu-core-dev/pulseaudio/ubuntu

  1. fix-01Pulseaudio-quoting
  2. Merge into ubuntu
Proposed by Chow Loong Jin
Status: Merged
Merge reported by: Daniel T Chen
Merged at revision: not available
Proposed branch: lp://qastaging/~hyperair/pulseaudio/fix-01Pulseaudio-quoting
Merge into: lp://qastaging/~ubuntu-core-dev/pulseaudio/ubuntu
Diff against target: 67 lines (+11/-11)
1 file modified
debian/01PulseAudio (+11/-11)
To merge this branch: bzr merge lp://qastaging/~hyperair/pulseaudio/fix-01Pulseaudio-quoting
Reviewer Review Type Date Requested Status
Daniel T Chen Approve
Review via email: mp+24505@code.qastaging.launchpad.net

Description of the change

Multiple fixes for 01Pulseaudio

* Drop -l from all su invocations, they cause su to do nothing.
* Fix su quoting issues:
  + Some shell functions were called within su's environment and didn't
    work.
  + Some variables were not substituted properly due to use of ' instead
    of ".

To post a comment you must log in.
Revision history for this message
Daniel T Chen (crimsun) wrote :

Works fine, thanks!

review: Approve
Revision history for this message
Daniel T Chen (crimsun) wrote :

I just noticed that this branch can't be merged against Lucid's release due to branch skew. I updated the bzr branch a couple uploads ago to use lp:~ubuntu-core-dev/pulseaudio/ubuntu.2a. Please rebase against that branch.

Revision history for this message
Chow Loong Jin (hyperair) wrote :

On Monday 03,May,2010 07:47 AM, Daniel T Chen wrote:
> I just noticed that this branch can't be merged against Lucid's release due to branch skew. I updated the bzr branch a couple uploads ago to use lp:~ubuntu-core-dev/pulseaudio/ubuntu.2a. Please rebase against that branch.

Done. Please try again.

--
Kind regards,
Chow Loong Jin

Revision history for this message
Daniel T Chen (crimsun) wrote :

Done, thanks!

For tracking, this merge was done into maverick's ubuntu.2a.maverick branch and will be pushed into lucid's ubuntu.2a branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: