Screenkey

Merge lp://qastaging/~iammuneeb/screenkey/numpad-5 into lp://qastaging/screenkey

numpad-5
Merge into trunk

Proposed by Muneeb Shaikh on 2012-02-07

Status:	Merged
Approved by:	Pablo SEMINARIO on 2012-02-09
Approved revision:	52
Merged at revision:	49
Proposed branch:	lp://qastaging/~iammuneeb/screenkey/numpad-5
Merge into:	lp://qastaging/screenkey
Diff against target:	130 lines (+32/-23) 1 file modified Screenkey/listenkbd.py (+32/-23)
To merge this branch:	bzr merge lp://qastaging/~iammuneeb/screenkey/numpad-5
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Pablo SEMINARIO		2012-02-07	Approve on 2012-02-09
Review via email: mp+91940@code.qastaging.launchpad.net

Description of the change

Fix for numpad key 5. Removed trailing whitespaces. Removed trailing space after numpad key 7.

lp://qastaging/~iammuneeb/screenkey/numpad-5 updated on 2012-02-08

52. By Muneeb Shaikh on 2012-02-08: added missing keys on numpad

Revision history for this message

Pablo SEMINARIO (pabluk) wrote on 2012-02-09:

Thanks for the fixes Muneeb

review: Approve

Revision history for this message

Muneeb Shaikh (iammuneeb) wrote on 2012-02-09:

@Pablo
I had also added remaining missing keys on numpad such as Enter key, +, -, *, / etc, but I didn't notice them before submitting the patch. I had added them to my branch but I couldn't propose merge as LP told me that there's already a merge request. You can take a diff and apply or I'll send the merge later.

Revision history for this message

Pablo SEMINARIO (pabluk) wrote on 2012-02-12:

@Muneeb

I merged the latest changes from your branch. If there are new changes to add from your branch can you please propose a new merge.

Thanks!

Revision history for this message

Muneeb Shaikh (iammuneeb) wrote on 2012-02-12:

@Pablo

You have added all the changes which I had made. If I make any changes I'll request new merge.

PS: I'm new to bzr and LP, and I was confused about sending two merge request one after the other, but LP took the latest changes as well, so I didn't need to make second merge request.