OpenLP

Merge lp://qastaging/~ic90/openlp/animated-alerts into lp://qastaging/openlp

  1. animated-alerts
  2. Merge into trunk
Proposed by Nico Opiyo
Status: Merged
Merged at revision: 2904
Proposed branch: lp://qastaging/~ic90/openlp/animated-alerts
Merge into: lp://qastaging/openlp
Diff against target: 1027 lines (+784/-41)
9 files modified
openlp/core/display/html/display.css (+80/-0)
openlp/core/display/html/display.html (+9/-4)
openlp/core/display/html/display.js (+240/-13)
openlp/core/display/window.py (+3/-2)
openlp/plugins/alerts/alertsplugin.py (+3/-1)
openlp/plugins/alerts/lib/alertsmanager.py (+33/-3)
openlp/plugins/alerts/lib/alertstab.py (+69/-17)
package.json (+1/-1)
tests/js/test_display.js (+346/-0)
To merge this branch: bzr merge lp://qastaging/~ic90/openlp/animated-alerts
Reviewer Review Type Date Requested Status
Tomas Groth Needs Fixing
Raoul Snyman Pending
Nico Opiyo Pending
Review via email: mp+369540@code.qastaging.launchpad.net

Commit message

Added scrolling alerts

Description of the change

Refactored the tests and optimized alert display code plus fixed spacing

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linux tests passed!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

Linting failed, please see https://ci.openlp.io/job/MP-03-Linting/134/ for more details

Revision history for this message
Tomas Groth (tomasgroth) wrote :

Limiting needs fixing

review: Needs Fixing
Revision history for this message
Tomas Groth (tomasgroth) wrote :

I tested a bit and found a few things:
When displaying a new scrolling alert, it does not seem to scroll slowly into view, instead it "jumps" a bit into the screen.
When using trying to activate a new alert, while an alert is already displayed, the new alert is never displayed.

review: Needs Fixing
Revision history for this message
Tomas Groth (tomasgroth) wrote :

This patch makes the queueing of alerts work: https://bin.snyman.info/mmm2y5nx

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.