Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://qastaging/~ignacio-nin/percona-server/5.1-debian-init-script into lp://qastaging/percona-server/5.1

5.1-debian-init-script
Merge into 5.1

Proposed by Ignacio Nin on 2013-09-22

Status:

Work in progress

Proposed branch:

lp://qastaging/~ignacio-nin/percona-server/5.1-debian-init-script

Merge into:

lp://qastaging/percona-server/5.1

Diff against target:

1820 lines (+0/-745)

5 files modified

build/debian/percona-server-server-5.1.mysql.init (+0/-182)
build/debian/percona-server-server-5.1.postinst (+0/-286)
build/debian/percona-server-server-5.1.postrm (+0/-83)
build/debian/percona-server-server-5.1.preinst (+0/-186)
build/debian/percona-server-server-5.1.prerm (+0/-8)

To merge this branch:

bzr merge lp://qastaging/~ignacio-nin/percona-server/5.1-debian-init-script

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Alexey Kopytov (community)	2013-09-22	Needs Information on 2013-10-16
Ignacio Nin (community)		Needs Resubmitting on 2013-09-30
Review via email: mp+186947@code.qastaging.launchpad.net

Description of the change

New debian init script from the upstream package

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2013-09-23:

- are there any specific bugs that this change is supposed to solve? If so, they should be referenced in comments/--fixes.

review: Needs Information

Revision history for this message

Ignacio Nin (ignacio-nin) wrote on 2013-09-30:

> - are there any specific bugs that this change is supposed to solve? If so,
> they should be referenced in comments/--fixes.

Resubmitting the merge with an updated --fixes pointing to bug lp:1072538. Other bugs referenced are lp:1204415 and lp:1215024, however because these were later bugs and actually pointed to the same underlying issue I've marked these as duplicates of the former.

review: Needs Resubmitting

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2013-10-16:

This way we lose some functionality present in the current init scripts. I.e. the init script will report the server as started (possibly long) before it is actually able to accept user connections. But OK, I see no way to avoid that.

A more serious issue is that we copy-paste Percona-Server/support-files/mysql.server to build-files/mysql-server-server-5.1.mysql.init

I know that that file is created from the mysql.server.sh template, and we also want to replace "MySQL" with "MySQL (Percona Server)". Can we instead modify support-files/mysql.server.sh to reference Percona Server and then modify the build scripts so that they use (copy) mysql.server as the package init script?

review: Needs Information

Unmerged revisions

579. By Ignacio Nin on 2013-09-30

Replace the debian init script with the script provided by source

The debian init script had some issues when it came to detecting the
server had been started -- it had a hardcoded 15 seconds wait (although
this could be overridden by my.cnf) and in order to detect a running
server it tried to login to it.

This came with issues when a) the startup time exceeded 15 seconds, which
is something that can easily happen with datasets of hundreds of gigs,
and b) if there was no user available for the init script to use, or the
user had been misconfigured somehow. Of course, these two possibilites
were true too often.

Replace the script with the one provided by MySQL, which uses a PID-file
based detection mechanism to check whether the server has been started or
stopped.

Given that the two init scripts share no common history (the previous one
came from the debian distribution), bzr rm and bzr add it to avoid
pointless conflicts.

578. By Ignacio Nin on 2013-09-10