Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://qastaging/~ignacio-nin/percona-server/5.5-debian-init-script into lp://qastaging/percona-server/5.5

5.5-debian-init-script
Merge into 5.5

Proposed by Ignacio Nin on 2013-09-22

Status:

Work in progress

Proposed branch:

lp://qastaging/~ignacio-nin/percona-server/5.5-debian-init-script

Merge into:

lp://qastaging/percona-server/5.5

Diff against target:

652 lines (+16/-193)

4 files modified

build/debian/percona-server-server-5.5.mysql.init (+0/-184)
build/debian/percona-server-server-5.5.postinst (+1/-1)
build/debian/percona-server-server-5.5.postrm (+7/-3)
build/debian/percona-server-server-5.5.preinst (+8/-5)

To merge this branch:

bzr merge lp://qastaging/~ignacio-nin/percona-server/5.5-debian-init-script

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Alexey Kopytov (community)	2013-09-22	Needs Information on 2013-10-16
Ignacio Nin (community)		Needs Resubmitting on 2013-09-30
Review via email: mp+186948@code.qastaging.launchpad.net

Description of the change

New debian init script from the upstream package

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2013-09-23:

- Comment for rev. 559 says file-id changes have been null-merged to 5.5, but I see that build/debian/percona-server-server-5.5.mysql.init still changes its file-id. Is that intentional?

- are there any specific bugs that this change is supposed to solve? If so, they should be referenced in comments/--fixes.

- the following change smells like a charset conversion issue:

658 - cp /usr/share/percona-server-common/internal-use-only/`echo $file | sed 's°/°_°g'` $file
659 + cp /usr/share/percona-server-common/internal-use-only/`echo $file | sed 'sï¿½/ï¿½_ï¿½g'` $file

review: Needs Fixing

Revision history for this message

Ignacio Nin (ignacio-nin) wrote on 2013-09-30:

> - Comment for rev. 559 says file-id changes have been null-merged to 5.5, but
> I see that build/debian/percona-server-server-5.5.mysql.init still changes its
> file-id. Is that intentional?

Yes, the file-id for this file is created new in 560, since it's a completely new file. 559 is indeed a null-merge.

>
> - are there any specific bugs that this change is supposed to solve? If so,
> they should be referenced in comments/--fixes.

Resubmitting with the same comments as for the 5.1 branch

>
> - the following change smells like a charset conversion issue:
>
> 658 - cp /usr/share/percona-server-common/internal-use-only/`echo $file |
> sed 's°/°_°g'` $file
> 659 + cp /usr/share/percona-server-common/internal-use-only/`echo $file |
> sed 'sï¿½/ï¿½_ï¿½g'` $file

Fix't-

review: Needs Resubmitting

Revision history for this message

Alexey Kopytov (akopytov) wrote on 2013-10-16:

Same question as in the 5.1 MP.

review: Needs Information

Revision history for this message

Raghavendra D Prabhu (raghavendra-prabhu) wrote on 2013-10-23:

The init script seems to be same as mysql.server.sh of centos.
Doesn't this require porting of some debian init script features?
For instance,

following is different in debian and centos:

# Required-Start: $local_fs $network $remote_fs
# Should-Start: ypbind nscd ldap ntpd xntpd
# Required-Stop: $local_fs $network $remote_fs

Unmerged revisions

560. By Ignacio Nin on 2013-09-30

Replace the debian init script with the script provided by source

The debian init script had some issues when it came to detecting the
server had been started -- it had a hardcoded 15 seconds wait (although
this could be overridden by my.cnf) and in order to detect a running
server it tried to login to it.

This came with issues when a) the startup time exceeded 15 seconds, which
is something that can easily happen with datasets of hundreds of gigs,
and b) if there was no user available for the init script to use, or the
user had been misconfigured somehow. Of course, these two possibilites
were true too often.

Replace the script with the one provided by MySQL, which uses a PID-file
based detection mechanism to check whether the server has been started or
stopped.

Given that the two init scripts share no common history (the previous one
came from the debian distribution), bzr rm and bzr add it to avoid
pointless conflicts. Merge this with the same fix for 5.1, and share the
file id with the corresponding file in that branch.

559. By Ignacio Nin on 2013-09-30