Merge lp://qastaging/~ijk/gtimelog/nutmeg into lp://qastaging/~gtimelog-dev/gtimelog/trunk
Proposed by
ijk
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merge reported by: | Marius Gedminas | ||||||||
Merged at revision: | not available | ||||||||
Proposed branch: | lp://qastaging/~ijk/gtimelog/nutmeg | ||||||||
Merge into: | lp://qastaging/~gtimelog-dev/gtimelog/trunk | ||||||||
Diff against target: |
267 lines (+78/-39) 5 files modified
NEWS.txt (+4/-2) README.txt (+12/-11) gtimelog.desktop (+2/-2) scripts/export-my-calendar.py (+4/-3) src/gtimelog/main.py (+56/-21) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~ijk/gtimelog/nutmeg | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marius Gedminas | Needs Fixing | ||
Review via email:
|
To post a comment you must log in.
This:
+ subject = 'Weekly report for {} (week {:0>2}) '.format( who, week)
means a UnicodeEncodeError if who is a unicode string with non-ASCII characters.
Although testing reveals that currently `who` is a byte string, which causes bug 1117109, so this doesn't make anything worse.
(It also drops support for Python 2.6 or older, which is probably fine. We'll see if anyone complains about that.)
There are some minor PEP-8 transgressions that I'll fix up after merging.
(Ick, launchpad's review UI sucks. Why haven't I moved to github already?)