Launchpad itself

Merge ~ilasc/launchpad:add-get-snapbuild-by-revision into launchpad:master

  1. Git
  2. lp:~ilasc/launchpad
  3. add-get-snapbuild-by-revision
  4. Merge into master
Proposed by Ioana Lasc
Status: Merged
Approved by: Ioana Lasc
Approved revision: 54adb9f372ec8e62c9ef5cd34452cf5351c0d0e0
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ilasc/launchpad:add-get-snapbuild-by-revision
Merge into: launchpad:master
Prerequisite: ~ilasc/launchpad:populate-store-upload-revision
Diff against target: 333 lines (+123/-36)
6 files modified
lib/lp/scripts/tests/test_garbo.py (+18/-36)
lib/lp/snappy/interfaces/snap.py (+15/-0)
lib/lp/snappy/model/snap.py (+14/-0)
lib/lp/snappy/model/snapbuildjob.py (+1/-0)
lib/lp/snappy/tests/test_snap.py (+49/-0)
lib/lp/snappy/tests/test_snapbuildjob.py (+26/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+407781@code.qastaging.launchpad.net

Commit message

Add getBuildByStoreRevision to Snap

Description of the change

This needs the new column "_store_upload_revision" to be added to SnapBuild and populated (prerequisite branch: populate-store-upload-revision).

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

As I noted in comments on the prerequisite MP, it seems likely that you'll need to adjust garbo tests here.

review: Needs Fixing
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: