Merge ~illia-v/ubuntu/+source/ubuntu-wallpapers/+git/ubuntu-wallpapers:python3 into ubuntu/+source/ubuntu-wallpapers:ubuntu/devel

debian/control:
1. Please do not change the Vcs fields. Our authoriative VCS is still bzr for this package until we can figure out a way to import our bzr history in to git. (And then we'll probably put it in ubuntu-desktop git instead of the git-ubuntu tree.)

2. I believe you can just Build-Depend on python3 instead of python3-all.

debian/rules:
3. The only line that looks needed to me is the dh line.

All of the above is fine as one commit. For other changes, please use separate commits.

4. It seems inconsistent to switch the top half of setup.py to separate the = operator by spaces on either side but then in the bottom half switch to not using spaces around the =.

5. What is the difference between changelog_file_path and changelog_file ? In other words, my initial reaction is that the initial "head=open" version is more readable.

6. One thing you can remove is the DPKG_GENSYMBOLS in debian/rules since we don't use symbols in this package since it's not a library. But please do that in a separate commit too.

7. I think the current Standards-Version is 4.2.1 but please use a separate commit for that change too.

Thanks for the review!

1. OK.

2. pybuild says it depends on python3-all (https://manpages.debian.org/wheezy-backports/dh-python/pybuild.1.en.html#DEBHELPER_COMMAND_SEQUENCER_INTEGRATION).

3. In my opinion, all changes in 'debian/rules' are required because pybuild workflow seems to be slightly different.

4. The code is consistent with style guide (PEP8). There are variable assignments in the first part and keyword arguments in the second one.

5. `head=open(changelog).readline()` opens the file but does not close it. It is a good practice to use the `with` statement for working with files in Python.

6. OK.

7. It seems that 4.2.1.2 was released on Oct 09. But I am not sure whether I should use 4.2.1.2 or 4.2.1. Do you know?

Will it be good if I create all commits in one branch and one merge request?
Can I reset the current branch and create new commits in it?

2. Thanks for pointing that out. I've been doing it wrong! (Most of the time we only support one python3 version but it's good to do it correctly.)

4 & 5. Thank you also!

7. I guess 4.2.1.2 works too but I usually just use the 3 digit version since that is good enough for lintian.

8. You can use "git push -f" to force push to your branch so that this merge proposal ends up having just the commits you want.

3. To be more specific, I'd prefer one commit for switching to python3, one for bumping the Standards-Version, and one for the pep8 fixes.

Please do the one-line dh change for debian/rules I recommended. The extra exports you do (mostly) create a python3-ubuntu-wallpapers package which we don't want.

By the way, I'm going to end up converting your work into bzr since we haven't converted our repo to git yet. I didn't mention it earlier because I don't want you to feel like you need to redo your work in bzr especially if you might not be familiar with using bzr.

Thank you!

I've split that commit in four ones.

No problem with converting it into bzr.