Merge lp://qastaging/~indicator-applet-developers/dbus-test-runner/no-werror into lp://qastaging/dbus-test-runner
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | 103 |
| Merged at revision: | 102 |
| Proposed branch: | lp://qastaging/~indicator-applet-developers/dbus-test-runner/no-werror |
| Merge into: | lp://qastaging/dbus-test-runner |
| Prerequisite: | lp://qastaging/~3v1n0/dbus-test-runner/new-priv-gobject-abi |
| Diff against target: |
92 lines (+9/-9) 4 files modified
build.sh (+1/-1) libdbustest/Makefile.am (+2/-2) src/Makefile.am (+1/-1) tests/Makefile.am (+5/-5) |
| To merge this branch: | bzr merge lp://qastaging/~indicator-applet-developers/dbus-test-runner/no-werror |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher | Approve | ||
| Marco Trevisan (Treviño) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2018-08-03.
Commit message
Don't build with -Werror, it causes unnecessary build failures
Description of the change
Resubmitting rebasing on lp:~3v1n0/dbus-test-runner/new-priv-gobject-abi
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the work, the 'removing -Werror' part looks good to me but I don't understand the code change/new symbol, why do we need that to be able to remove Werror? It would be nice if those changes who be at least described in the changelog (or split in another commit if that's orthogonal to the dropping of Werror)