Merge lp://qastaging/~indicator-applet-developers/hud/callback-fix into lp://qastaging/hud/13.10

Proposed by Antti Kaijanmäki
Status: Merged
Approved by: Pete Woods
Approved revision: 312
Merged at revision: 311
Proposed branch: lp://qastaging/~indicator-applet-developers/hud/callback-fix
Merge into: lp://qastaging/hud/13.10
Diff against target: 285 lines (+117/-39)
4 files modified
src/abstract-app.h (+10/-6)
src/application-list.c (+102/-28)
src/application-source.c (+4/-4)
src/dbusmenu-collector.c (+1/-1)
To merge this branch: bzr merge lp://qastaging/~indicator-applet-developers/hud/callback-fix
Reviewer Review Type Date Requested Status
Pete Woods (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+181379@code.qastaging.launchpad.net

Commit message

Fix Ubuntu UI Session callbacks.

On Touch Images where we use Ubuntu UI Session API to get
notifications when active window changes. The callbacks
are being invoked from a separate thread. We have to
pass the callbacks through g_idle_add() to process them
in main gmaincontext.

This also requires to change the type of AbstractWindow and
AbstractApp as we can't pass on the ubuntu_ui_session_properties
accross different threads.

Description of the change

    Fix Ubuntu UI Session callbacks.

    On Touch Images where we use Ubuntu UI Session API to get
    notifications when active window changes. The callbacks
    are being invoked from a separate thread. We have to
    pass the callbacks through g_idle_add() to process them
    in main gmaincontext.

    This also requires to change the type of AbstractWindow and
    AbstractApp as we can't pass on the ubuntu_ui_session_properties
    accross different threads.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
312. By Antti Kaijanmäki

add missing HAVE_PLATFORM_API

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Pete Woods (pete-woods) wrote :

Nice job

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: