Merge lp://qastaging/~indicator-applet-developers/ido/add-messaging-menu into lp://qastaging/ido/13.10

Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 148
Merged at revision: 145
Proposed branch: lp://qastaging/~indicator-applet-developers/ido/add-messaging-menu
Merge into: lp://qastaging/ido/13.10
Diff against target: 1163 lines (+1044/-2)
11 files modified
debian/libido3-0.1-0.symbols (+10/-0)
src/Makefile.am (+8/-2)
src/idoactionhelper.c (+24/-0)
src/idoactionhelper.h (+3/-0)
src/idoapplicationmenuitem.c (+195/-0)
src/idoapplicationmenuitem.h (+36/-0)
src/idodetaillabel.c (+401/-0)
src/idodetaillabel.h (+59/-0)
src/idomenuitemfactory.c (+8/-0)
src/idosourcemenuitem.c (+264/-0)
src/idosourcemenuitem.h (+36/-0)
To merge this branch: bzr merge lp://qastaging/~indicator-applet-developers/ido/add-messaging-menu
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+179962@code.qastaging.launchpad.net

Commit message

Add widgets for messaging menu

Description of the change

Adds the widgets needed for messaging menu integration. Might be broken, getting a diff and Jenkins comment right now while doing further testing.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
147. By Ted Gould

Adding new symbols

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:147
http://jenkins.qa.ubuntu.com/job/ido-ci/33/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-saucy-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-saucy-armhf-ci/15

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ido-ci/33/rebuild

review: Approve (continuous-integration)
148. By Ted Gould

Library functions taking GVariant params need to ref_sink() and unref() always. (reason #24 to not like GVariant)

Revision history for this message
Ted Gould (ted) wrote :

Fixed a couple of little things. But this seems sane.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:148
http://jenkins.qa.ubuntu.com/job/ido-ci/34/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-saucy-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-saucy-armhf-ci/16

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ido-ci/34/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: