Code review comment for lp://qastaging/~indicator-applet-developers/indicator-messages/consolidate

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, that looks better, still some issue:

- the order is still wrong, default im client and mailer should be first

- the libindicate parser copy seems a lot of undeed code, can we do without it?

- the spacing between the icons and status seems wrong, but I guess that's a bug somewhere else in the stack since e.g indicator-bluetooth seems to have the same issue

« Back to merge proposal